Add MLX dispatch for CholeskySolve - #2377
Merged
Merged
Conversation
ricardoV94
approved these changes
Aug 25, 2026
jessegrabowski
force-pushed
the
mlx-cho-solve
branch
from
August 25, 2026 23:56
31a0631 to
d517dab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLX has no cho_solve, so this runs two triangular solves against the Cholesky factor and its transpose.
Every op in the dispatch, including the transpose, is pinned to the CPU stream. mlx.linalg is CPU-only, and a transpose left on the default stream aborts on float64 input.